Skip to content

Bump stdarch #134333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2024
Merged

Bump stdarch #134333

merged 1 commit into from
Dec 24, 2024
+11 −19

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Dec 15, 2024 •
edited
Loading

This bumps stdarch to rust-lang/stdarch@684de0d to get in rust-lang/stdarch#1677 (tracked in #133908).

From the commit history I deduced that there shouldn't be any changes to Rust necessary.

From past PRs I'm assuming that bumping stdarch like this is fine, but please let me know if this is somehow inappropriate or requires something more to be done!

try-job: arm-android
try-job: armhf-gnu

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 15, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@daxpedda daxpedda mentioned this pull request Dec 15, 2024
Merged
@daxpedda daxpedda marked this pull request as draft December 15, 2024 10:25
@daxpedda
Copy link
Contributor Author

Fixed failure in rust-lang/stdarch#1692.

@daxpedda daxpedda marked this pull request as ready for review December 21, 2024 14:01
@daxpedda
Copy link
Contributor Author

daxpedda commented Dec 21, 2024 •
edited
Loading

r? @Amanieu

I think is more appropriate.

@rustbot rustbot assigned Amanieu and unassigned Mark-Simulacrum Dec 21, 2024
@Amanieu
Copy link
Member

Amanieu commented Dec 23, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 23, 2024

📌 Commit f90a536 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2024
@daxpedda
Copy link
Contributor Author

@Amanieu I think something went wrong here and it didn't end up in the queue.

@Amanieu
Copy link
Member

Amanieu commented Dec 24, 2024

@bors ping

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

😪 I'm awake I'm awake

@Amanieu Amanieu closed this Dec 24, 2024
@Amanieu Amanieu reopened this Dec 24, 2024
@Amanieu
Copy link
Member

Amanieu commented Dec 24, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

📌 Commit f90a536 has been approved by Amanieu

It is now in the queue for this repository.

@Amanieu
Copy link
Member

Amanieu commented Dec 24, 2024

@bors rollup=never

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

⌛ Testing commit f90a536 with merge 17e6acb...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Amanieu
Copy link
Member

Amanieu commented Dec 24, 2024

@bors rollup=maybe

@Amanieu
Copy link
Member

Amanieu commented Dec 24, 2024

@bors delegate+

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

✌️ @daxpedda, you can now approve this pull request!

If @Amanieu told you to "r=me" after making some further change, please make that change, then do @bors r=@Amanieu

@daxpedda
Copy link
Contributor Author

try-jobs are still not triggered. I will continue to try it out with r+ unfortunately.

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

📌 Commit 923aba9 has been approved by daxpedda

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@daxpedda
Copy link
Contributor Author

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

📌 Commit db651a0 has been approved by daxpedda

It is now in the queue for this repository.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@daxpedda
Copy link
Contributor Author

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

📌 Commit 374800b has been approved by daxpedda

It is now in the queue for this repository.

@daxpedda
Copy link
Contributor Author

While we are at it:
@bors rollup=never

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

⌛ Testing commit 374800b with merge 409998c...

@bors
Copy link
Collaborator

bors commented Dec 24, 2024

☀️ Test successful - checks-actions
Approved by: daxpedda
Pushing 409998c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 24, 2024
@bors bors merged commit 409998c into rust-lang:master Dec 24, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 24, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (409998c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)		 -0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Max RSS (memory usage)

Results (primary 2.9%, secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 5.4% [2.5%, 10.7%] 6
Regressions ❌
(secondary)		 4.1% [4.1%, 4.1%] 1
Improvements ✅
(primary)		 -4.3% [-5.9%, -2.7%] 2
Improvements ✅
(secondary)		 -3.4% [-3.4%, -3.4%] 1
All ❌✅ (primary) 2.9% [-5.9%, 10.7%] 8

Cycles

Results (secondary 3.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.8% [3.8%, 3.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.3%] 6
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.6%, -0.0%] 22
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.0% [-0.6%, 0.3%] 28

Bootstrap: 762.9s -> 763.56s (0.09%)
Artifact size: 330.67 MiB -> 330.63 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Amanieu Amanieu

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.85.0

Development

Successfully merging this pull request may close these issues.

8 participants

@daxpedda @rustbot @rust-log-analyzer @Amanieu @bors @calebzulawski @rust-timer @Mark-Simulacrum